From 1eebe6c8de7f366d2210dd7d88d2c6a0df39be6f Mon Sep 17 00:00:00 2001
From: Dan Wallis <dan@wallis.nz>
Date: Mon, 26 Jun 2023 17:33:17 +0100
Subject: [PATCH] Only detect and remove <script> attributes

Before this change, the sniff would alert on (and remove) any non-PHP text
which matched, not only <script> attributes.
---
 Magento2/Sniffs/Legacy/PhtmlTemplateSniff.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Magento2/Sniffs/Legacy/PhtmlTemplateSniff.php b/Magento2/Sniffs/Legacy/PhtmlTemplateSniff.php
index f020b061..bc44466e 100644
--- a/Magento2/Sniffs/Legacy/PhtmlTemplateSniff.php
+++ b/Magento2/Sniffs/Legacy/PhtmlTemplateSniff.php
@@ -74,9 +74,9 @@ private function checkBlockVariable(File $phpcsFile, int $stackPtr, array $token
     private function checkHtml(File $phpcsFile, int $stackPtr): void
     {
         $content = $phpcsFile->getTokensAsString($stackPtr, 1);
-        $pattern = '_\s+type=(["\'])text/javascript\1_i';
+        $pattern = '_(<script[^>\s]*)\stype=(["\'])text/javascript\2_i';
 
-        if (preg_match($pattern, $content)) {
+        if (preg_match($pattern, $content, $matches)) {
             $fix = $phpcsFile->addFixableWarning(
                 'Please do not use "text/javascript" type attribute.',
                 $stackPtr,
@@ -84,7 +84,7 @@ private function checkHtml(File $phpcsFile, int $stackPtr): void
             );
 
             if ($fix) {
-                $content = preg_replace($pattern, '', $content);
+                $content = preg_replace($pattern, $matches[1], $content);
                 $phpcsFile->fixer->replaceToken($stackPtr, $content);
             }
         }