Issue with hash parameter for has_many_attached

[marktong11]

First of all, cool tool. One issue I am having is that has_many_attached does not currently work when specifying folder names.

send_zip {'Holidays in Lyon <3' => Holidays.where(place: 'lyon').first.pictures}

is currently giving an error NoMethodError: undefined method `filename' for #ActiveStorage::Attached::Many:0x00007fe05eef4818

This works though:

send_zip {'Holidays in Lyon <3' => Holidays.where(place: 'lyon').first.pictures.records}

[madeindjs]

Sorry for my late reply. Did you have this problem on current version ?

[robwold]

I can confirm I've had the same problem on the current version. The above suggestion with records looks like it works (although for some reason I'm finding that image files are also getting corrupted by the zipping process 🤔 )

EDIT: I've had a poke around, and I think that the root of the issue is that ActiveStorage::Attached::Many responds false to .is_a? Array https://github.com/madeindjs/active_storage-send_zip/blob/master/lib/active_storage/send_zip_helper.rb#L41