You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are supposed to be 13 red and white stripes on the US flag -- one for each of the original 13 colonies. FlagKit's current rendition has 15. Not only is this numerically incorrect, but it distorts the appearance of the flag as well.
The asset itself is in @1x 15 px high, I would have had to make two of the stripes 2px and the other eleven 1px. And that would look super bad. So it's a design compromise sadly.
May I suggest instead of making some stripes 2px for @1x (which would indeed look super bad), that you instead simply omit the last two stripes, which shouldn't be there anyway? Flags cannot be made to fit into identical heights and widths because they have so many different aspect ratios and detail positioning. I believe most users will prefer a 13px height flag that's correct and has the expected aesthetic over one that is a targeted 15px that's factually wrong and aesthetically odd-looking.
Here are the before and after of the proposed change at @1x:
There are supposed to be 13 red and white stripes on the US flag -- one for each of the original 13 colonies. FlagKit's current rendition has 15. Not only is this numerically incorrect, but it distorts the appearance of the flag as well.
I found your earlier justification unconvincing:
May I suggest instead of making some stripes 2px for @1x (which would indeed look super bad), that you instead simply omit the last two stripes, which shouldn't be there anyway? Flags cannot be made to fit into identical heights and widths because they have so many different aspect ratios and detail positioning. I believe most users will prefer a 13px height flag that's correct and has the expected aesthetic over one that is a targeted 15px that's factually wrong and aesthetically odd-looking.
Here are the before and after of the proposed change at @1x:
Before: (15 stripes – wrong)
After: (13 stripes – correct)
This pull request has similar fixes for @1x, @2x, @3x, and SVG. Hope you like this.
The text was updated successfully, but these errors were encountered: