Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US flag is wrong: too many stripes #76

Open
kjhughes opened this issue Sep 7, 2019 · 0 comments
Open

US flag is wrong: too many stripes #76

kjhughes opened this issue Sep 7, 2019 · 0 comments

Comments

@kjhughes
Copy link

kjhughes commented Sep 7, 2019

There are supposed to be 13 red and white stripes on the US flag -- one for each of the original 13 colonies. FlagKit's current rendition has 15. Not only is this numerically incorrect, but it distorts the appearance of the flag as well.

I found your earlier justification unconvincing:

The asset itself is in @1x 15 px high, I would have had to make two of the stripes 2px and the other eleven 1px. And that would look super bad. So it's a design compromise sadly.

May I suggest instead of making some stripes 2px for @1x (which would indeed look super bad), that you instead simply omit the last two stripes, which shouldn't be there anyway? Flags cannot be made to fit into identical heights and widths because they have so many different aspect ratios and detail positioning. I believe most users will prefer a 13px height flag that's correct and has the expected aesthetic over one that is a targeted 15px that's factually wrong and aesthetically odd-looking.

Here are the before and after of the proposed change at @1x:

Before: US flag too many stripes (15 stripes – wrong)
After: US flag correct number of stripes (13 stripes – correct)

This pull request has similar fixes for @1x, @2x, @3x, and SVG. Hope you like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant