From ff01375a21c9e39ccacb54166aa0655c1838b19b Mon Sep 17 00:00:00 2001 From: Joe Lust Date: Fri, 10 Jan 2025 10:36:35 -0500 Subject: [PATCH] Doc update: swap legacy browser names (#66) * Update old browser references --- README.md | 2 +- test/suite.test.ts | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index b7c57f0..4f4beb4 100644 --- a/README.md +++ b/README.md @@ -104,7 +104,7 @@ jobs: [curl builder](https://app.mabl.com/workspaces/-/settings/apis#api-docs-selector-dropdown-button) to find the id. - `browser-types` {string} (optional): comma or new line separated override for browser - types to test e.g. `chrome, firefox, safari, internet_explorer`. If not + types to test e.g. `chrome, firefox, webkit, edge`. If not provided, mabl will test the browsers configured on the triggered test. - `plan-labels` {string} (optional): comma or new line separated plan labels to test. Plans matching **any** label will be run. e.g. `smoke-test, beta-feature`. Note: additional selection criteria must also be met like application-id or environment-id, if supplied. - `uri` {string} (optional, DEPRECATED - use app_url) the base uri to run browser based tests against. If provided, this will diff --git a/test/suite.test.ts b/test/suite.test.ts index 7f34e63..5d97253 100644 --- a/test/suite.test.ts +++ b/test/suite.test.ts @@ -36,8 +36,8 @@ describe('GitHub Action tests', () => { setGithubInput(ActionInputs.BrowserTypes, 'chrome, firefox '); expect(optionalArrayInput(ActionInputs.BrowserTypes)).toEqual(['chrome', 'firefox']); - setGithubInput(ActionInputs.BrowserTypes, 'chrome\nfirefox\nsafari '); - expect(optionalArrayInput(ActionInputs.BrowserTypes)).toEqual(['chrome', 'firefox', 'safari']); + setGithubInput(ActionInputs.BrowserTypes, 'chrome\nfirefox\nwebkit\nedge '); + expect(optionalArrayInput(ActionInputs.BrowserTypes)).toEqual(['chrome', 'firefox', 'webkit', 'edge']); }); it('parses boolean inputs', () => { @@ -123,7 +123,7 @@ describe('GitHub Action tests', () => { environment_id: 'env', application_id: 'app', plan_overrides: { - browser_types: ['firefox', 'chrome', 'internet_explorer'], + browser_types: ['firefox', 'chrome', 'edge'], web_url: 'fake-app-url', api_url: 'fake-api-url', }, @@ -145,7 +145,7 @@ describe('GitHub Action tests', () => { }; const apiClient = new MablApiClient('test'); const requestBody = apiClient.buildRequestBody( - ['firefox', 'chrome', 'internet_explorer'], + ['firefox', 'chrome', 'edge'], [], [], true,