Skip to content
This repository has been archived by the owner on Oct 17, 2018. It is now read-only.

Sample pooling #22

Open
xichen2020 opened this issue Jun 5, 2017 · 1 comment
Open

Sample pooling #22

xichen2020 opened this issue Jun 5, 2017 · 1 comment

Comments

@xichen2020
Copy link
Contributor

I have experimented with sampling pooling by using

  • a pool of fixed-size (64) list of samples, in which case the p99 write latency has become higher and spikier)
  • a pool of fixed-size (64) full array of samples and a pool of fixed-size empty array of samples (this is to pool the array after the samples are used), in which case the cpu used to be allocated for creating samples is no longer seen in the profile, but the p99 write latency/ flush interval / cpu load remained the same.

Punting this for now, may pick this back up when there's more time.

@jeromefroe
Copy link
Contributor

On a side note, when we do revisit this in the future it may be worth trying the sync.Pool in the standard library to see if it offers any benefits for our particular workload.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants