-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
URL discovery in CSV files where values are not wrapped in quotes #1299
Comments
Thanks for creating the issue. |
@mre - thank you for your response. Yes, definitely, I can open an issue there and request feedback. |
@robinst suggested using a CSV parser and pass individual cells to linkify. This has a few advantages:
I think this is the way forward. @cicdguy, perhaps you want to close the linkify issue again, and we can focus on fixing this issue in lychee itself as per the above plan? What do you think? 😃 |
Sounds great. Thank you @mre! |
Hello,
I'm using lychee 0.13.0 and running it against this file:
https://github.com/pharmaverse/admiraldiscovery/blob/06e6e55b884ef91de9ae457606ed66defc9dba14/data-raw/admiral-lookup-book.csv
Like so:
And I get the following result:
When I modify the file by adding quotes around the URLs in the CSV, I get the correct expected result.
Although commas are allowed/safe characters in URLs, will it be possible for Lychee to detect CSV files and extract URLs from it without having to wrap the URL strings in quotes?
The text was updated successfully, but these errors were encountered: