-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrobbles should happen earlier, not at the end of the track playback #30
Comments
With reading the issue on the last.fm plugin, I have to disagree. At no point in both ListenBrainz or last.fm documentation is such thing specified. Both platforms just specify the conditions which must be met for sending the data, but everything else is left up to the client. ListenBrainz documentation only specifies the conditions:
— https://listenbrainz.readthedocs.io/en/latest/users/api/core.html#post--1-submit-listens And last.fm documentation you linked in the lastfm plugin issue gives similar conditions:
Last.fm documentation then goes on explicitly mentioning that once the conditions have been met, the scrobble can be sent at any time:
— https://www.last.fm/api/scrobbling#when-is-a-scrobble-a-scrobble While
So, basically, unless I'm missing something, developing such feature would cost too much with no benefits. Of course, you can always try to prove otherwise or just implement this feature yourself. Now, for the issues with 3rd party clients not reporting playback event, this has been worked around in this plugin with introduction of alternative detection mode (documented here) - as long as the client marks items as played on the server. |
Closing due to inactivity. |
This is similar to what I explained in the last.fm plugin (jesseward/jellyfin-plugin-lastfm#50). Scrobbles should happen earlier, preferably as soon as the condition for scrobble has been met and not rely on the stop event from the player as it's known to have issues. More details in the other issue, including an idea of how to do it.
The text was updated successfully, but these errors were encountered: