Package lxdock as a snap #179
Conversation
|
Continuing the discussion with @robvdl from #146 (comment) : |
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
=======================================
Coverage 91.41% 91.41%
=======================================
Files 45 45
Lines 1351 1351
=======================================
Hits 1235 1235
Misses 116 116Continue to review full report at Codecov.
|
| @@ -13,7 +13,7 @@ upgrade: | |||
| pip install -e . -U | |||
|
|
|||
| lint: | |||
| flake8 | |||
| flake8 --exclude snap,parts,stage,prime | |||
There was a problem hiding this comment.
can go in setup.cfg the exclude stuff, I thought we already had some there
There was a problem hiding this comment.
But setup.cfg doesn't get used if I just run make lint on the command line during development.
There was a problem hiding this comment.
I'll have a look when I get back in November but yes the flake8 tool does read setup.cfg for config if there is a [flake8] section. If we are to publish snaps using travis it has to be on merge, but to be honest I am not a huge fan of snaps and didn't really want to get involved in maintenance of snaps but I'll have a look in early November. Problem with the project is I'm the only person still merging stuff for the last 2 years and I'm insanely busy sometimes it takes a while as I like to test everything properly.
|
So the requirements-test.txt would be the appropriate choice?
…On 1 March 2020 02:03:31 CET, Rob van der Linde ***@***.***> wrote:
robvdl commented on this pull request.
> @@ -0,0 +1,20 @@
+name: lxdock
+version: git
+summary: lxdock
+description: |
+ Build and orchestrate your development environments with LXD
+ - a.k.a. Vagrant is Too Heavy
+base: core18
+confinement: strict
+
+parts:
+ lxdock:
+ plugin: python
+ python-version: python3
+ source: .
+ requirements: requirements-dev.txt
am I reading this right? do the dev requirements end up in the snap?
why? we don't need them in the snap or any other kind of binary
distribution like deb/rpm
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#179 (review)
|
|
Neither, the way this project is actually setup:
so really you just need setup.py in order to run the app |
|
Rebased. |
|
Ping |
1 similar comment
|
Ping |
|
I'm in the middle of an import project with fixed deadline, likeliless I can get to it before November is quite slim. |
|
I'm so sorry for all the work that has gone into this and then it not even getting merged. I tried for a while to look after this project but it just turned out to be impossible by myself. I'm sorry for this and being a let down to not seeing this through and getting merged. We did get others putting their hand up to help years and years ago but nothing ever came of that, even then it seemed to be just me maintaining it. I now have not even run or tested lxdock for over 3 years and have created a ticket to move the entire repo to archival status and declare the project dead, just nobody even seems to care about that anymore because a year on and not a single comment on that ticket. |
Instructions how to build a use a snap package of lxdock.
I also updated the LXD installation part of the documentation, to primarily suggest a snap based installation, since that is the official method Cannonical suggests and it also allows a more easy integration on other distributions than Ubuntu.
I would suggest to merge this as a first step as is, and later on adapt the Travis configuration to automatically build and publish an official package.
Fixes #156