Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency [funcool/cuerdas "2021.05.29-0"] breaks funcool/struct #547

Open
javahippie opened this issue Sep 8, 2021 · 1 comment
Open

Comments

@javahippie
Copy link
Contributor

javahippie commented Sep 8, 2021

When creating a new luminus app with the following command:

lein new luminus my-app +reitit +re-frame +shadow-cljs +postgres

And running

lein uberjar

The compilation fails:

Compiling my-app.config
       Compiling my-app.core
       Compiling my-app.db.core
       Compiling my-app.env
       Compiling my-app.handler
       Compiling my-app.layout
       Compiling my-app.middleware
       Compiling my-app.middleware.formats
       Compiling my-app.nrepl
       Compiling my-app.routes.home
       Compiling my-app.validation
       Syntax error compiling at (struct/core.cljc:218:31).
       Syntax error compiling at (struct/core.cljc:218:31).
       No such var: str/parse-number
       
       Full report at:
       /tmp/clojure-6721617795244421863.edn

There was no such error in an older luminus app I run, so I compared the project.clj files and realized that [funcool/cuerdas "2021.05.29-0"] overrides a transient dependency of [funcool/struct "1.4.0"], which relies on [funcool/cuerdas "2.2.0"].
If I remove the reference to cuerdas from the project.clj file, everything works as expected.

It seems to be a recent addition, so I'd expect only version 4.17 to be affected:
0ff6cd9

@javahippie javahippie changed the title Dependency [funcool/cuerdas "2021.05.29-0"] breaks funcool&struct Dependency [funcool/cuerdas "2021.05.29-0"] breaks funcool/struct Sep 8, 2021
@yogthos
Copy link
Member

yogthos commented Sep 8, 2021

Thanks for the report, that does look like a break in the API that I missed unfortunately. I've rolled back the template for now and submitted a patch for struct to address the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants