Fixing Barcode length validation updated for PDF417 and Code128 #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@igorocampos I see the change to the other barcode variable length checks, but for the PDF one, is it really only necessary to change the length limit? the rest of the code already works correctly for longer strings? have you been able to test this on a printer? |
Unfortunately, I haven't :( But according to the manual, there's no actual limit other than what you mentioned in #253, so in theory it should work. But yeah, it would be nice to have it actually tested in a printer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253
Based on below manuals, length cap was wrong for PDF417 and Code128