Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect to another endpoint if designation is a synthetic object #4

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

JeremyMcCormick
Copy link
Collaborator

@JeremyMcCormick JeremyMcCormick commented May 29, 2024

If the object designation does not have a space, assume it is synthetic and redirect to an endpoint which will print a message to that effect.

@JeremyMcCormick JeremyMcCormick requested a review from gpdf May 29, 2024 22:12
@JeremyMcCormick JeremyMcCormick force-pushed the u/jeremym/dev branch 5 times, most recently from 47f54a7 to bc57a4f Compare May 30, 2024 00:10
Copy link

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "synthetic object" endpoint needs to return HTML to match the expected MIME type from the service descriptor.

src/mpclookup/handlers/external.py Outdated Show resolved Hide resolved
If the object has a space in it, then redirect to another API endpoint
which indicates that it is synthetic.
@JeremyMcCormick JeremyMcCormick merged commit 7aad254 into main Aug 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants