-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Unable to save settings" in WebStorm #128
Comments
Hmm same error happens when I change the GUI compact mode (though the setting seems to be applied then). Also reported upstream: https://youtrack.jetbrains.com/issue/WEB-63366/Unable-to-save-settings-in-WebStorm-each-time-when-changing-a-setting-after-updating-to-232.10072.28 |
Upstream (IntelliJ) devs helped and it seems to be an issue about this plugin. Because if I disable it, everything works again and GUI settings can be saved. IntelliJ log here: https://gist.github.com/rklec/aafa74ccaecf8f59badde1d1086a2fa2 |
Linked to #124. Having a look now. |
Looks like I managed to get an infinite loop into a regexp. That's quite an accomplishment. The good way to solve this problem is to phase out the commit message parsing using regexp, and instead rely on the language support. I need to improve the lexer for that. |
Yeah infinite RegEx'es are bad. It's a common problem: https://stackoverflow.com/questions/15919146/regular-expression-goes-into-infinite-loop Is there any solution for now or could you push a hotfix release with some bad commit reverted (if you need, "git bisect" is always great to find a problematic commit.), as this issue makes the whole extension unusable? |
STR
I open the settings and change the paths to some custom-made CoAuthors file and token JSON:
I then click save.
What happens
If I restart WebStorm as stated, the settings are reset/back as the old ones again.
And if I change the settings again then, the issue happens again. So this issue is reproducible.
What should happen
No error.
This has worked previously (in Rider e.g.).
System
(I have just updated to the last WebStorm version.)
The text was updated successfully, but these errors were encountered: