Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small suggestions #24

Closed
telemachus opened this issue Aug 28, 2017 · 2 comments
Closed

Two small suggestions #24

telemachus opened this issue Aug 28, 2017 · 2 comments

Comments

@telemachus
Copy link

telemachus commented Aug 28, 2017

Thanks for sharing this and writing up your experiences making it! As the title says, I have two small suggestions.

First, and just fyi for your README, this built for me on macOS (10.12.6) without trouble (I already have the build tools installed for gcc, but many people checking out the repo will too). I have a fair number of packages installed via Homebrew already, but I haven't installed ncurses. Anyhow, you might mention that Apple users can likely try it out too.

Second, maybe consider swapping your default task in the Makefile from run to build? I found it disconcerting to hit make and to end up in the editor. I found it even more disconcerting to have the executable disappear after I quit it! I like the neatness of run for people just trying it out, but it was confusing at first. However you go on the default, maybe say something in the README about the Makefile. (All of this said, it's my own fault for not reading the Makefile before I ran make!)

@lpan
Copy link
Owner

lpan commented Aug 28, 2017

Thanks for your contribution 👍 🖌️

For 1 I do not own any device that runs macOS, it will be awesome if someone can add macOS setup instruction 🙂

As for 2, I totally agree! I will fix it right now

@lpan
Copy link
Owner

lpan commented Aug 28, 2017

Close this in favour of #26

@lpan lpan closed this as completed Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants