-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: add tracing support #160
Comments
The storage is an interface, so you should be able to simply replace it with your extended version of the storage. Take a look in the builders in If possible I'd suggest to introduce the tracing via builders instead of adding another dependency to the main package. Sami has been working in a rewrite of the storage package. @SamiHiltunen, do you think that the rewrite would help introducing tracing? |
@db7 thanks for the information. I didn't realize they are all interfaces and I'll look into it. I guess it would still make sense if goka provides open-tracing support out of box. |
I looked into
|
Good points. I'd be more than happy reviewing PRs for this issue and #77. If you'd like to try, please let me know. I can support you via chat if you need help to get started. |
sounds good. I'll let you know when I get time for working on this issue. |
I'll close it for now, reopen or create a new issue if it comes up again. |
I think there is definitely an interest in using tracing with goka. Right now to use https://godoc.org/gopkg.in/DataDog/dd-trace-go.v1/contrib/Shopify/sarama with a producer you need to implement a custom Line 32 in 3d39c5a
There is deffinitely an overhead caused by having to maintain copy pasted @frairon @db7 please could you reopen this issue? Will the goka core team accept a PR that improves the tracing support? |
@adw1n sorry for the late response, we're currently all on vacation and I honestly forgot to reply to you before. I'd be happy to review any PRs that would add that. Thanks in advance for the contribution :) |
Hey, I tried to add tracing for sarama and LevelDB using these two libraries:
https://godoc.org/gopkg.in/DataDog/dd-trace-go.v1/contrib/Shopify/sarama
https://godoc.org/gopkg.in/DataDog/dd-trace-go.v1/contrib/syndtr/goleveldb/leveldb
but I failed to do so because producer/consumer/leveldb.DB are not exposed directly.
#77 adding header to goka context may be helpful but we still can't get traces of emitter/view/groupTable.
I think it would be good to add opentracing support to the options of Emitter/processor/view:
https://github.com/opentracing/opentracing-go
any suggestion on how to add tracing to goka for now?
The text was updated successfully, but these errors were encountered: