Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing timeout on story collection #184

Closed
chriskalmar opened this issue Sep 21, 2022 · 4 comments
Closed

Missing timeout on story collection #184

chriskalmar opened this issue Sep 21, 2022 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@chriskalmar
Copy link
Collaborator

Bug description

When the Storybook build is broken, the story collection process seems to be neverending.
I simple timeout should

How to reproduce

  1. run broken storybook (or just any page that has no stories)
  2. run lostpixel
  3. process is hanging at Trying to collect stories via window object

Expected behavior

Should fail after a defined timeout

Lost Pixel information

lost-pixel logs from CI

No response

@chriskalmar chriskalmar added the good first issue Good for newcomers label Sep 21, 2022
@Capocaccia
Copy link

Ill take this one!

@joaogarin
Copy link
Contributor

Is this one still relevant? I see that there is a timeout of 30sec that comes I think from playwright-core

page.waitForFunction: Timeout 30000ms exceeded.

is the main goal here having a specific timeout that is handled by lost-pixel here https://github.com/lost-pixel/lost-pixel/blob/main/src/crawler/storybook.ts#L273 and not playwright? 🤔

@d-ivashchuk
Copy link
Collaborator

I think this might not be so relevant anymore as we throw errors on timeouts. At least I've never experienced a broken storybook resulting in never ending run lately 😀

@joaogarin
Copy link
Contributor

I think this might not be so relevant anymore as we throw errors on timeouts.

yes I think so too, at least to me this doesn't seem to really get stuck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants