Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing timeout on story collection #184

Open
chriskalmar opened this issue Sep 21, 2022 · 1 comment
Open

Missing timeout on story collection #184

chriskalmar opened this issue Sep 21, 2022 · 1 comment
Assignees
@Capocaccia
Labels
good first issue Good for newcomers

Comments

@chriskalmar
Copy link
Collaborator

Bug description

When the Storybook build is broken, the story collection process seems to be neverending.
I simple timeout should

How to reproduce

  1. run broken storybook (or just any page that has no stories)
  2. run lostpixel
  3. process is hanging at Trying to collect stories via window object

Expected behavior

Should fail after a defined timeout

Lost Pixel information

lost-pixel logs from CI

No response
@chriskalmar chriskalmar added the good first issue Good for newcomers label Sep 21, 2022
@Capocaccia
Copy link

Ill take this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Capocaccia Capocaccia

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chriskalmar @Capocaccia @d-ivashchuk