Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#LAMS conditional comments ignored with \r line terminator #88

Open
Leogiciel opened this issue Apr 25, 2022 · 3 comments
Open

#LAMS conditional comments ignored with \r line terminator #88

Leogiciel opened this issue Apr 25, 2022 · 3 comments

Comments

@Leogiciel
Copy link

Sorry if I missed something, but here are my manifest file and the output I have.
image
It really looks like the file is read but ignored.
Any clue about this ?
Thanks and regards :)

@fabio-looker
Copy link
Collaborator

Hi @Leogiciel

This is the first time I believe have seen this particular issue. As you can see from the second line in the table, the parser has not found any properties within your manifest file.

I think this is most likely due to an issue with the "conditional comment" feature not working, since there is no syntax error reported. Although the relevant regex is supposed to work on the first line as well, perhaps that is not working correctly and adding a leading line break would fix it?

I also notice you have numerous instances of undefined locations throughout the report. Which version of LAMS are you running?

If neither of these suggestions helps, you can email your manifest file to me ([email protected]) and I can try to reproduce the issue too.

@fabio-looker
Copy link
Collaborator

Also... are you perhaps on an OS/system that encodes line breaks with a carriage return character? That is not something that my regex seems to account for.

@Leogiciel
Copy link
Author

Hi @fabio-looker , and thank you for your help.
It was definitely the CRLF encoding. Manifest works fine in LF.

Nice catch !

You can close this issue, if you don't want to follow this regex, and thanks again :)

@fabio-looker fabio-looker changed the title Rules exemptions don't apply #LAMS conditional comments ignored with \r line terminator Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants