Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fulfilled order price might change in time #281

Open
dtwm opened this issue Dec 24, 2019 · 0 comments
Open

Fulfilled order price might change in time #281

dtwm opened this issue Dec 24, 2019 · 0 comments
Labels
Milestone

Comments

@dtwm
Copy link

dtwm commented Dec 24, 2019

  • longclaw version: 1

In current implementation order price is determent from current product price. https://github.com/JamesRamm/longclaw/blob/a041d3d505539f03dce4d0570f067ecc1eb4e7a9/longclaw/orders/models.py#L91-L93

Product price might change with time, value of paid (or accepted) orders shouldn't. This also will bite once sales and discounts will be introduced.
btw, relation to product via on_change=DO_NOTHING might lead to unexpected results.

@JamesRamm JamesRamm added the bug label Dec 24, 2019
@JamesRamm JamesRamm added this to the 1.1 Release milestone Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants