Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new handle when the backend application is offline #1550

Merged
merged 2 commits into from Mar 22, 2024

Conversation

Cristhianzl
Copy link
Collaborator

✨ (App.tsx): Import the useNavigate hook from react-router-dom to enable programmatic navigation within the app.
πŸ“ (App.tsx): Add comments to explain the purpose of the isLoadingHealth state variable and the checkApplicationHealth function.
πŸ“ (App.tsx): Add comments to explain the purpose of the onHealthCheck function.
πŸ› (App.tsx): Fix a bug where the checkApplicationHealth function was not being called when the component mounts.
πŸ› (App.tsx): Fix a bug where the onHealthCheck function was not being called when the health check was successful.
πŸ“ (App.tsx): Add comments to explain the purpose of the checkApplicationHealth function and the onHealthCheck function.
✨ (fetchErrorComponent/index.tsx): Import the BaseModal component from the modals/baseModal module to display the fetch error component in a modal.
✨ (fetchErrorComponent/index.tsx): Import the Button component from the ui/button module to display a retry button in the fetch error component.
✨ (fetchErrorComponent/index.tsx): Add a retry button to the fetch error component to allow the user to retry the failed request.
✨ (ui/dialog-with-no-close.tsx): Create a new file ui/dialog-with-no-close.tsx to define a custom dialog component without a close button.
✨ (ui/dialog-with-no-close.tsx): Define the Dialog, DialogTrigger, DialogPortal, DialogOverlay, DialogContent, DialogHeader, DialogFooter, DialogTitle, and DialogDescription components for the custom dialog component.

πŸ“ (baseModal/index.tsx): add support for a new type prop to switch between modal and dialog mode
πŸ› (baseModal/index.tsx): fix typo in import statement for Modal and ModalContent components
♻️ (baseModal/index.tsx): refactor BaseModal component to conditionally render either Modal or Dialog based on the type prop
πŸ› (flowsManagerStore.ts): fix issue where isLoading state was not being set to false after catching an error
πŸ› (typesStore.ts): fix issue where error alert was not being shown when fetching types failed
πŸ› (typesStore.ts): remove unnecessary error alert when fetching types failed
✨ (components/index.ts): add new properties to fetchErrorComponentType to support opening a modal, retrying, and showing loading state

… enable programmatic navigation within the app.

πŸ“ (App.tsx): Add comments to explain the purpose of the `isLoadingHealth` state variable and the `checkApplicationHealth` function.
πŸ“ (App.tsx): Add comments to explain the purpose of the `onHealthCheck` function.
πŸ› (App.tsx): Fix a bug where the `checkApplicationHealth` function was not being called when the component mounts.
πŸ› (App.tsx): Fix a bug where the `onHealthCheck` function was not being called when the health check was successful.
πŸ“ (App.tsx): Add comments to explain the purpose of the `checkApplicationHealth` function and the `onHealthCheck` function.
✨ (fetchErrorComponent/index.tsx): Import the `BaseModal` component from the `modals/baseModal` module to display the fetch error component in a modal.
✨ (fetchErrorComponent/index.tsx): Import the `Button` component from the `ui/button` module to display a retry button in the fetch error component.
✨ (fetchErrorComponent/index.tsx): Add a retry button to the fetch error component to allow the user to retry the failed request.
✨ (ui/dialog-with-no-close.tsx): Create a new file `ui/dialog-with-no-close.tsx` to define a custom dialog component without a close button.
✨ (ui/dialog-with-no-close.tsx): Define the `Dialog`, `DialogTrigger`, `DialogPortal`, `DialogOverlay`, `DialogContent`, `DialogHeader`, `DialogFooter`, `DialogTitle`, and `DialogDescription` components for the custom dialog component.

πŸ“ (baseModal/index.tsx): add support for a new type prop to switch between modal and dialog mode
πŸ› (baseModal/index.tsx): fix typo in import statement for Modal and ModalContent components
♻️ (baseModal/index.tsx): refactor BaseModal component to conditionally render either Modal or Dialog based on the type prop
πŸ› (flowsManagerStore.ts): fix issue where isLoading state was not being set to false after catching an error
πŸ› (typesStore.ts): fix issue where error alert was not being shown when fetching types failed
πŸ› (typesStore.ts): remove unnecessary error alert when fetching types failed
✨ (components/index.ts): add new properties to fetchErrorComponentType to support opening a modal, retrying, and showing loading state
@Cristhianzl Cristhianzl self-assigned this Mar 22, 2024
Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated (UTC)
langflow βœ… Ready (Inspect) Visit Preview Mar 22, 2024 1:44am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request javascript Pull requests that update Javascript code labels Mar 22, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 22, 2024
@ogabrielluiz ogabrielluiz merged commit 496c2aa into zustand/io/migration Mar 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants