Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent esc to close Code Modal #1544

Merged
merged 1 commit into from Mar 19, 2024
Merged

Conversation

Cristhianzl
Copy link
Collaborator

✨ (codeAreaModal/index.tsx): add event listener to prevent the Escape key from closing the modal
📝 (codeAreaModal/index.tsx): improve code readability by adding line breaks and indentation for better code organization

… key from closing the modal

📝 (codeAreaModal/index.tsx): improve code readability by adding line breaks and indentation for better code organization
@Cristhianzl Cristhianzl self-assigned this Mar 19, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request javascript Pull requests that update Javascript code labels Mar 19, 2024
Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 6:04pm

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 19, 2024
@anovazzi1 anovazzi1 self-requested a review March 19, 2024 20:55
Copy link
Contributor

@anovazzi1 anovazzi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anovazzi1 anovazzi1 merged commit 43023e5 into zustand/io/migration Mar 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants