Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logseq Sync's deletion handling outside of standard folder is buggy #11278

Closed
andelf opened this issue Apr 30, 2024 · 0 comments · Fixed by #11280
Closed

Logseq Sync's deletion handling outside of standard folder is buggy #11278

andelf opened this issue Apr 30, 2024 · 0 comments · Fixed by #11280
Assignees
Labels
Logseq Sync :type/bug Something isn't working. Affects daily use.

Comments

@andelf
Copy link
Collaborator

andelf commented Apr 30, 2024

This is reported by the community.

If you copy logseq to logseq-bak folder, then this folder will never be deleted from Logseq Sync. Every time it deletes, it'll be fetched at the next time.

Cause:

  • Some fs changes in this folder are ignored by fs watcher (ignore folder name) - This implementation is wrong
  • After app restarts, Initial get-local-metadata notifies all files
  • After a remote-local comparison, remote files are fetched again
@andelf andelf added :type/bug Something isn't working. Affects daily use. Logseq Sync labels Apr 30, 2024
@andelf andelf self-assigned this Apr 30, 2024
andelf added a commit that referenced this issue Apr 30, 2024
andelf added a commit that referenced this issue May 8, 2024
andelf added a commit that referenced this issue May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Logseq Sync :type/bug Something isn't working. Affects daily use.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant