Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut "Code Block" does not support Org-mode source format #11060

Open
jbfil opened this issue Feb 29, 2024 · 0 comments · May be fixed by #11061
Open

Shortcut "Code Block" does not support Org-mode source format #11060

jbfil opened this issue Feb 29, 2024 · 0 comments · May be fixed by #11061

Comments

@jbfil
Copy link

jbfil commented Feb 29, 2024

I expect to use the preferred format for source block formatting.

Source link to problem area. Shortcut invoked with the /Code Block command uses markdown formatting always.

logseq/src/main/frontend/commands.cljs

Lines 302 to 305 in 7ac3a64

["Code block" [[:editor/input "```\n```\n" {:type "block"
:backward-pos 5
:only-breakline? true}]
[:editor/select-code-block-mode]] "Insert code block"]]

Example of where the preferred format is used for the < shortcut key.

logseq/src/main/frontend/components/shortcut_help.cljs

Lines 53 to 71 in 7ac3a64

raw (case preferred-format
:markdown {:bold (str "**" (t :bold) "**")
:italics (str "_" (t :italics) "_")
:link "[Link](https://www.example.com)"
:del (str "~~" (t :strikethrough) "~~")
:mark (str "^^" (t :highlight) "^^")
:latex "$$E = mc^2$$"
:code (str "`" (t :code) "`")
:pre "```clojure\n (println \"Hello world!\")\n```"
:img "![image](https://asset.logseq.com/static/img/logo.png)"}
:org {:bold (str "*" (t :bold) "*")
:italics (str "/" (t :italics) "/")
:del (str "+" (t :strikethrough) "+")
:pre [:pre "#+BEGIN_SRC clojure\n (println \"Hello world!\")\n#+END_SRC"]
:link "[[https://www.example.com][Link]]"
:mark (str "^^" (t :highlight) "^^")
:latex "$$E = mc^2$$"
:code "~Code~"
:img "[[https://asset.logseq.com/static/img/logo.png][image]]"})

Solution may be as easy as adding a preferred block selection. Not sure though since I don't program clojurescript.
jbfil added a commit to jbfil/logseq that referenced this issue Feb 29, 2024
@jbfil
Use preferred-format in "Code Block" shortcut
ea3d104 
fixes logseq#11060
@jbfil jbfil linked a pull request Feb 29, 2024 that will close this issue
Open
jbfil added a commit to jbfil/logseq that referenced this issue Mar 4, 2024
@jbfil
Use preferred-format in "Code Block" shortcut
1a74dc0 
fixes logseq#11060
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use preferred-format in "Code Block" shortcut jbfil/logseq
1 participant
@jbfil