Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider value not passed correctly by GlobalFlags #1391

Open
abdulari opened this issue Nov 16, 2024 · 0 comments
Open

provider value not passed correctly by GlobalFlags #1391

abdulari opened this issue Nov 16, 2024 · 0 comments
Labels

Comments

@abdulari
Copy link

What happened?

  • provider value not passed correctly by GlobalFlags for provider set-options
  • provider value is passed correctly by GlobalFlags for provider options

What did you expect to happen instead?
both provider options and provider set-options able to get provider value correctly from GlobalFlags

How can we reproduce the bug? (as minimally and precisely as possible)

add log.Debugf("GlobalFlags=%+v", cmd.GlobalFlags) in set_options.go Run function

vscode ➜ /workspaces/devpod (main) $ devpod provider set-options docker --provider docker2 --debug
09:55:23 debug GlobalFlags={Context: Provider: LogOutput:plain Debug:false Silent:false AgentDir: DevPodHome: UID:}
09:55:23 done Successfully set options for provider 'docker'
vscode ➜ /workspaces/devpod (main) $ 
vscode ➜ /workspaces/devpod (main) $ devpod provider options docker --provider docker2 --debug
09:56:52 debug GlobalFlags=&{Context: Provider:docker2 LogOutput:plain Debug:true Silent:false AgentDir: DevPodHome: UID:}
  
-- truncate --

Local Environment:

  • DevPod Version: commit 37e66ce34ab125f8fb4952d6041a2ca159ca2603
  • Operating System: linux and windows
  • ARCH of the OS: AMD64

DevPod Provider:

  • Local/remote provider: docker

Anything else we need to know?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant