Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seed function in Hook should get AppContext as an argument. #1060

Open
DenuxPlays opened this issue Dec 7, 2024 · 3 comments · May be fixed by #1063
Open

seed function in Hook should get AppContext as an argument. #1060

DenuxPlays opened this issue Dec 7, 2024 · 3 comments · May be fixed by #1063
Labels
enhancement New feature or request

Comments

@DenuxPlays
Copy link
Contributor

Feature Request

Currently the seed function only gets the DatabaseConnection but it should get the AppContext as an argument.

Describe the solution you'd like

Yeah basically as I said.
Change the arguments or extend it.

Describe alternatives you've considered

None

Extras

I would like to work on this if it gets approved.
@DenuxPlays DenuxPlays added the enhancement New feature or request label Dec 7, 2024
@DenuxPlays
Copy link
Contributor Author

Makes more sense together with: #972

@DenuxPlays DenuxPlays linked a pull request Dec 7, 2024 that will close this issue
Open
@kaplanelad
Copy link
Contributor

can you describe the uae case?

@DenuxPlays
Copy link
Contributor Author

can you describe the uae case?

Considering the other ticket (#972) it might be useful to get the AppContext as an argument.
For example I have services that need AppContext as an argument to create them.
Currently it's useless as only files can get used to create fixtures.

In my case I have a Snowflake Generator which i need to use inside the fixtures but the generator requires the AppContext as an argument.

TLDR:
It's only useful with #972 if this ticket/pr gets declined this is to no use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixtures use AppContext instead of DatabaseConnection DenuxPlays/loco
2 participants
@kaplanelad @DenuxPlays