Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] 在 language_model_settings 关闭时,在模型服务商页面仍然可以点击弹出模型设置页面 #5170

Open
opoet opened this issue Dec 24, 2024 · 3 comments · May be fixed by #5171
Labels
🐛 Bug Something isn't working | 缺陷

Comments

@opoet
Copy link

opoet commented Dec 24, 2024

📦 部署环境

Vercel

📌 软件版本

1.39.0

💻 系统环境

Windows

🌐 浏览器

Chrome

🐛 问题描述

在 language_model_settings 关闭时,在模型服务商页面点击配置服务商仍然可以弹出模型设置页面,如下图
image

📷 复现步骤

No response

🚦 期望结果

No response

📝 补充信息

No response

@opoet opoet added the 🐛 Bug Something isn't working | 缺陷 label Dec 24, 2024
@github-project-automation github-project-automation bot moved this to Roadmap - Chat 1.x in Lobe Chat Routine Dec 24, 2024
@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


📦 Deployment environment

Vercel

📌 Software version

1.39.0

💻 System environment

Windows

🌐 Browser

Chrome

🐛 Problem description

When language_model_settings is closed, click Configure Service Provider on the model service provider page to still pop up the model settings page, as shown below
image

📷 Steps to reproduce

No response

🚦 Expected results

No response

📝 Supplementary information

No response

@lobehubbot
Copy link
Member

👀 @opoet

Thank you for raising an issue. We will investigate into the matter and get back to you as soon as possible.
Please make sure you have given us as much context as possible.
非常感谢您提交 issue。我们会尽快调查此事,并尽快回复您。 请确保您已经提供了尽可能多的背景信息。

Copy link

dosubot bot commented Dec 24, 2024

@opoet 你好!我是Dosu,一个可以帮助你解决软件问题、回答你的问题,并帮助你成为贡献者的机器人。我会在等待人类维护者的时候帮助你。期待与你合作!🤖

The issue you're encountering seems to be related to the language_model_settings feature toggle. When this feature is disabled, the model settings page should not be accessible. However, it appears that the settings can still be accessed from the model provider page.

The showLLM state is responsible for controlling the visibility of the language model settings page. It is derived from the language_model_settings feature flag. If showLLM is false, the settings page should not be displayed, and a "not found" response should be returned instead [1][2].

To address this issue, you might want to check if the showLLM state is being correctly evaluated in the UI components responsible for rendering the model provider page. Ensure that there is conditional logic in place to prevent the settings page from being accessed when language_model_settings is disabled.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@opoet opoet linked a pull request Dec 24, 2024 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working | 缺陷
Projects
Status: Roadmap - Chat 1.x
Development

Successfully merging a pull request may close this issue.

2 participants