Slight confusion with amp= vs amplitude=... in make_params() #892
Replies: 3 comments 4 replies
-
@PennyWieser sorry for being dense, but where did the syntax change? Basically, the arguments to |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
@PennyWieser OK, thanks, that helps clarify the problem. I think this is a real bug. I'm sort of surprised we don't have a test or example for that! I also think that the fix here is easy. If you're up for it, I think the hotfix of changing that Line 697 to We'll have to add tests for this and then get a fix in, and then push out 1.2.2 soon. |
Beta Was this translation helpful? Give feedback.
-
Hi, First off, I love lmfit so much!
I just upgraded from 1.0.2 to 1.2.0, and I notice the syntax for
params = model.make_params() has changed
it used to take amplitude= as an arguement, now it wants amp=..
Similarly, center= has gone to cen=
But when I then print the parameters I have made, it is called amplitude and center again.
I couldnt seem to find any documentation explaining this syntax difference/change and I was just wondering if its intentional, or whether this is an old fashioned away of making parameters I shouldnt be using any more?
Thanks so much!
Beta Was this translation helpful? Give feedback.
All reactions