Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Split off more code from plugin/src/lib.rs into submodules #99

Open
llogiq opened this issue May 3, 2018 · 3 comments
Open
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@llogiq
Copy link
Owner

llogiq commented May 3, 2018

The plugin source is currently split into two files, one of which is auto-generated by build.rs. The lib.rs is getting unwieldy. Time to browse for sets of functionality that can be put into their own modules, before navigating the source gets too cumbersome.

@llogiq llogiq added help wanted Extra attention is needed good first issue Good for newcomers labels May 3, 2018
@gnieto
Copy link
Collaborator

gnieto commented May 3, 2018

Do you mean splitting each kind of mutation into a specific MultiModifier? If you don't mean this, what would you think about doing that?

@llogiq
Copy link
Owner Author

llogiq commented May 3, 2018

No, I'm rather thinking about other random stuff, like our custom TyOcc + Hash + Equals implementation. The default type whitelist stuff is likely to be removed anyway when #100 is done.

And for the record, I don't think we should split our Mutator just yet. It may make sense once we want to deactivate certain mutations by configuration, but we don't have that yet, and I'm not convinced the extra complication is worth it.

@rexto
Copy link

rexto commented Jul 6, 2018

I'd like to help with this issue. I'm a complete beginner, I just finished reading Rust-book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants