-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Excel (maybe aother attachments types) creates duplicate Loader ID's #63
Comments
When you say query loader, what do you mean? |
when you use query the loaders this way, ragApplication.loaders you get a json list of the types loaded, i use this to built my front end list, which is when i noticed uploading the same excel twice created two entires when querying the ragApplication object and using loaders method to get the latest list. Hope that helps |
There was never an intent (originally) to maintain a single instance of a unique loader as the unique identifier was only used to delete the vector values from the database if the loader was previously seen. I reflected on this issue and decided to not maintain duplicates (by removing older versions of loaded loaders or newer versions of loaders being loaded in parallel). Have published a new version |
Now |
I can confirm on adding excel named file, it indexes,and lists from the get loaders method. Adding it again, only one entry appears in the list from loaders I also observed this with the web loaders too so appears to be fixed Job well done! |
In v0.77, two entires Duplicate ID's
I would expect it would at the very least to create a new different Loader ID or if its able to determine the spreadsheet is same as before (filename matched) it will not add it and return a "could not add, as named resource already exists"
The text was updated successfully, but these errors were encountered: