Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for VertexAI for Gemini LLM and Embedding #46

Closed
tsibg opened this issue May 8, 2024 · 3 comments
Closed

Support for VertexAI for Gemini LLM and Embedding #46

tsibg opened this issue May 8, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@tsibg
Copy link
Contributor

tsibg commented May 8, 2024

I am interested in support for Gemini models, preferably on VertexAI by Google Cloud Platform.
The Gemini 1.5 Pro supports up to 1M Context, which could open a bunch of possibilities for grounding and RAG. Further more it is multimodal (text, images, audio, PDFs, code, videos).

Resources for the integration:

LLM and Embedding models on VertexAI:

Langchain LLM support for VertexAI and all Gemini models:

Langchain Embeddings on VertexAI (Expirimental):
Supports both textembedding-gecko and multimodalembedding@001

I'm currently working on the integration, it looks pretty straight forward.
Will also submit a PR, if the authors are interested.

P.S. Thanks for creating this library, well structured and easy to use.

@adhityan
Copy link
Collaborator

adhityan commented May 9, 2024

Thank you @tsibg both for engaging and also for the PR. Let's get it merged in.

@adhityan adhityan added the enhancement New feature or request label May 9, 2024
adhityan added a commit that referenced this issue May 10, 2024
Support Gemini LLM and Embeddings on VertexAI #46
@tsibg
Copy link
Contributor Author

tsibg commented May 10, 2024

Thanks for merging it.

Just a few ideas for future implementations:

  • Gemini also supports multimodal. It can directly accept PDF, video, images. Maybe it is bit out of scope for this library, but in case anyone needs it, the integration can be updated.
  • Same for the Embeddings: the LangChain's module have different class for multi modal embeddings, it could be implemented. However, not sure how it will work with the rest of the library.

Closing this issue as my use case is fully covered with the merge. Thanks again for the fast collab!

@tsibg tsibg closed this as completed May 10, 2024
@adhityan
Copy link
Collaborator

Published new version 0.0.72 with merged changes.

I like the idea of natively supporting multimodal. RAG is still useful in a multimodal setup. I will start a discussion thread on the best way to go ahead with support for this in the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants