-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this component compatible with IOS 11? #21
Comments
It use api of swiftui, ofcause it not compatible with IOS 11 |
I analyzed its source code and built it with UIKit API |
Yes, this library is combine uikit with swiftui, this is this library is doing, but it contain swiftui , and swiftui is a library which is noly support ios 13 and above. so this library is not compatible with IOS 11. you can try to build this library with ios 11, you will get failed if you try. |
It doesn't use swiftui features, just some IOS 13 features It can be supported. If it relies on swiftui, it can also do swiftui. What is the significance of its existence? |
I didn't see that it imported the relevant framework of swiftui, but just used some iOS13 supported features of UIKit, which can be compatible with lower versions. |
I checked all the code, It does not use swiftui api, but you need to make basetoolbox to compatible with ios11, It should compatible with IOS 11 |
Yes, I have studied all the codes of basetoolbox. It can be compatible with IOS 11 |
Yes, problem fixed! |
You guys are correct that this project doesn't use SwiftUI. If you want to put up a PR supporting iOS11. I can merge it in as long as it doesn't remove any existing functionality. |
This seems a bit cumbersome, and the code of basetoolbox needs to be adapted to iOS11 first. I have a local demo that has done this, and I will submit some prs later. |
I maintain an Extensions is also a simple extension that includes basetoolbox to see if I need to switch from basetoolbox to Extensions |
I submitted a pr but there is still a iOS 13 version limitation on the use of some, I don't know how to replace it PR22 |
似乎使用some关键字就只能支持iOS 13以上了,需要把some替换成any,这可能需要改一些实现逻辑。另外状态绑定不像SwiftUI使用起来那么简单,建议可以参考 SwiftWebUI / ComponentKit实现一下。 |
Is this component compatible with IOS 11
The text was updated successfully, but these errors were encountered: