Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this component compatible with IOS 11? #21

Open
fanglinwei opened this issue Dec 21, 2021 · 12 comments
Open

Is this component compatible with IOS 11? #21

fanglinwei opened this issue Dec 21, 2021 · 12 comments

Comments

@fanglinwei
Copy link

Is this component compatible with IOS 11

@zzycami
Copy link

zzycami commented Jan 20, 2022

It use api of swiftui, ofcause it not compatible with IOS 11

@fanglinwei
Copy link
Author

It use api of swiftui, ofcause it not compatible with IOS 11

I analyzed its source code and built it with UIKit API

@zzycami
Copy link

zzycami commented Jan 20, 2022

Yes, this library is combine uikit with swiftui, this is this library is doing, but it contain swiftui , and swiftui is a library which is noly support ios 13 and above. so this library is not compatible with IOS 11. you can try to build this library with ios 11, you will get failed if you try.

@fanglinwei
Copy link
Author

Yes, this library is combine uikit with swiftui, this is this library is doing, but it contain swiftui , and swiftui is a library which is noly support ios 13 and above. so this library is not compatible with IOS 11. you can try to build this library with ios 11, you will get failed if you try.

It doesn't use swiftui features, just some IOS 13 features It can be supported. If it relies on swiftui, it can also do swiftui. What is the significance of its existence?

@fanglinwei
Copy link
Author

Yes, this library is combine uikit with swiftui, this is this library is doing, but it contain swiftui , and swiftui is a library which is noly support ios 13 and above. so this library is not compatible with IOS 11. you can try to build this library with ios 11, you will get failed if you try.

I didn't see that it imported the relevant framework of swiftui, but just used some iOS13 supported features of UIKit, which can be compatible with lower versions.

@zzycami
Copy link

zzycami commented Jan 20, 2022

I checked all the code, It does not use swiftui api, but you need to make basetoolbox to compatible with ios11, It should compatible with IOS 11

@fanglinwei
Copy link
Author

I checked all the code, It does not use swiftui api, but you need to make basetoolbox to compatible with ios11, It should compatible with IOS 11

Yes, I have studied all the codes of basetoolbox. It can be compatible with IOS 11

@zzycami
Copy link

zzycami commented Jan 20, 2022

I checked all the code, It does not use swiftui api, but you need to make basetoolbox to compatible with ios11, It should compatible with IOS 11

Yes, I have studied all the codes of basetoolbox. It can be compatible with IOS 11

Yes, problem fixed!

@lkzhao
Copy link
Owner

lkzhao commented Jan 20, 2022

You guys are correct that this project doesn't use SwiftUI. If you want to put up a PR supporting iOS11. I can merge it in as long as it doesn't remove any existing functionality.

@fanglinwei
Copy link
Author

你们是对的,这个项目不使用 SwiftUI。如果你想建立一个支持 iOS11 的 PR。只要它不删除任何现有功能,我就可以合并它。

This seems a bit cumbersome, and the code of basetoolbox needs to be adapted to iOS11 first. I have a local demo that has done this, and I will submit some prs later.

@fanglinwei
Copy link
Author

You guys are correct that this project doesn't use SwiftUI. If you want to put up a PR supporting iOS11. I can merge it in as long as it doesn't remove any existing functionality.

I maintain an Extensions is also a simple extension that includes basetoolbox to see if I need to switch from basetoolbox to Extensions

@fanglinwei
Copy link
Author

You guys are correct that this project doesn't use SwiftUI. If you want to put up a PR supporting iOS11. I can merge it in as long as it doesn't remove any existing functionality.

I submitted a pr but there is still a iOS 13 version limitation on the use of some, I don't know how to replace it PR22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants