-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reproduce results #78
Comments
Thanks for the interests in the work and the feedback. The following tips may help reproduce the results:
Hope this can help, and feel free to update this thread if you have encountered issues. |
Yep, it does not work in the METR-LA dataset. Although I have used the same codes on the server, it is worse than the results you give. Of course, I have read the tips you provide, but it is non-helpful for me. I want to know how others' experimental results. Thank you for your reply. |
Thank you for providing the log, and spending time debugging this. It seems that there may be some discrepancies, as even a naive baseline approach considering constant traffic could yield significantly better accuracy. Additionally, would you kindly share the version of Tensorflow that you are currently using? It is important to note that the provided code has solely been tested with Tensorflow 1.x, and may not function properly with Tensorflow 2.x. Attached is my training log from 2020 with Tensorflow 1.14.0, which I hope will be of assistance: https://gist.github.com/liyaguang/f689b004f6aa04f6767bbadaeb808d47. Furthermore, I have conducted another run today, the results of which were quite comparable. In the following days, I plan to allocate time to test it on Tensorflow 2.0. |
Dear Li, it's okay to test codes on the pre-trained model weights you give (i.e., ). However, I couldn't get the results when I trained the model myself. The version of TensorFlow is 1.14. |
I have uploaded the new version to my personal page, https://github.com/zouguojian/Traffic-speed-prediction/tree/main/3S-TBLN/baseline/DCRNN. you can download these codes on your local device to run. looking forward your reply |
Thank you for sharing the code. Would it be possible for you to confirm whether your can train unmodified code using Tensorflow 1.x (not compat model from 2.x)? This code appears to be designed for Tensorflow 2.x in compat model rather than native 1.x. In the meantime, I will also investigate how to make the code work with Tensorflow 2.x (in compat model). Thanks for your kind understanding. |
Yep, dear Li, maybe you are right. I have used the high version of TensorFlow to be compatible low version. |
I have solved this problem in PyTorch!!! |
Great job! It's wonderful to hear that you were able to solve the problem using PyTorch! If you want to, feel free to share your solution with others |
|
Who can reproduce similar results on the METR-LA dataset? My result is worse than this paper.
The text was updated successfully, but these errors were encountered: