Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: litestar run CLI has several readability issues #3822

Open
4 tasks
sobolevn opened this issue Oct 16, 2024 · 3 comments
Open
4 tasks

Bug: litestar run CLI has several readability issues #3822

sobolevn opened this issue Oct 16, 2024 · 3 comments
Labels
Bug 🐛 This is something that is not working as expected CLI This is related to our CLI

Comments

@sobolevn
Copy link
Member

sobolevn commented Oct 16, 2024

Description

First problem: low contrast on light theme:

Снимок экрана 2024-10-16 в 23 04 11

I can hardly read what grey and yellow texts say.
One can argue that this is a problem of my setup / theme, but I've never seen this before in other apps.

Second problem:
Снимок экрана 2024-10-16 в 23 04 06

Option's name of --create-self-signed-c... (certificate?) is cut. I think that this is the most important part of the help here. And it should not cut the options' names.

The same happens with --unix-domain-so…

URL to code causing the issue

No response

MCVE

No response

Steps to reproduce

1. Run `litestar run -h`

Screenshots

No response

Logs

No response

Litestar Version

main

Platform

  • Linux
  • Mac
  • Windows
  • Other (Please specify in the description above)

Note

While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.

Check out all issues funded or available for funding on our Polar.sh dashboard

  • If you would like to see an issue prioritized, make a pledge towards it!
  • We receive the pledge once the issue is completed & verified
  • This, along with engagement in the community, helps us know which features are a priority to our users.
Fund with Polar
@sobolevn sobolevn added Bug 🐛 This is something that is not working as expected CLI This is related to our CLI labels Oct 16, 2024
@github-project-automation github-project-automation bot moved this to Triage in Overview Oct 16, 2024
@provinzkraut
Copy link
Member

I don't think we can change this, as it's something coming from rich-click. That library has caused us a lot of trouble though, so maybe it's time to ditch this in 3.0 (or just move away from click in general :)).

@JacobCoffee, @DanCardin

@Alc-Alc
Copy link
Contributor

Alc-Alc commented Dec 11, 2024

@provinzkraut is there a reason max width is set to 80 here, setting that to a different value should help with part of this issue

rich_click.rich_click.MAX_WIDTH = 80

@provinzkraut
Copy link
Member

@provinzkraut is there a reason max width is set to 80 here, setting that to a different value should help with part of this issue

rich_click.rich_click.MAX_WIDTH = 80

Not that I know of. I think @cofin introduced this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 This is something that is not working as expected CLI This is related to our CLI
Projects
Status: Triage
Development

No branches or pull requests

3 participants