Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Command completion #851

Open
Sebobo opened this issue Feb 12, 2021 · 2 comments
Open

Feature request: Command completion #851

Sebobo opened this issue Feb 12, 2021 · 2 comments
Labels
feature request Requested feature

Comments

@Sebobo
Copy link

Sebobo commented Feb 12, 2021

It would be great to have a command autocompletion and possibly a callback to provide further completions.

Similar to how it's done here https://github.com/rohanchandra/javascript-terminal/blob/af6ab7c18e595341c3e2d5a79e07f68cb51ef2c2/src/emulator/auto-complete.js

I would try to implement this as a PR but wanted to open an issue first to get feedback.
Maybe @linuswillner you already have some thoughts about it?

@linuswillner
Copy link
Owner

Hmm. This feature has not been suggested to me before; however, I do think it might be worth implementing, considering how often this kind of feature is used in native terminals and the immense amount of utility it provides.

However, unfortunately, due to being rather occupied in my private life for the time being, it would probably take a good while for me to have time to work on this myself. If you can find a solid way to implement this system, I'd be more than happy to accept a PR for it. 😄

@linuswillner linuswillner added the feature request Requested feature label Feb 12, 2021
@suffle
Copy link

suffle commented Mar 20, 2021

I opened a PR that adds a callback function prop that is called on tab, That way you can implement command completion on your own:

#898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requested feature
Projects
None yet
Development

No branches or pull requests

3 participants