update scala to support java 21 #2139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of java interop issues have been resolved in scala: https://github.com/scala/scala/pulls?q=label%3A%22java+interop%22+is%3Aclosed As it stands compiling using jdk 21 fails with: ``` 116.0 > Task :cruise-control:compileScala 116.0 error: 116.0 bad constant pool index: 0 at pos: 48461 116.0 while compiling: <no file> 116.0 during phase: globalPhase=<no phase>, enteringPhase=<some phase> 116.0 library version: version 2.13.10 116.0 compiler version: version 2.13.10 ``` Its not clear which of the versions between .10 and .13 resolves it but I think its safe to move to .13 which also happens to resolve the compile issue.
pkelly03
approved these changes
Apr 1, 2024
slaupster
changed the title
slaupster
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of java interop issues have been resolved in scala:
https://github.com/scala/scala/pulls?q=label%3A%22java+interop%22+is%3Aclosed
As it stands compiling using jdk 21 fails with:
Its not clear which of the versions between .10 and .13 resolves it but I think its safe to move to .13 which also happens to resolve the compile issue.
This PR resolves #2138.