Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to run tests on macos due to missing GeoIP.h #813

Open
ssbarnea opened this issue Mar 26, 2024 · 0 comments · May be fixed by #814
Open

Unable to run tests on macos due to missing GeoIP.h #813

ssbarnea opened this issue Mar 26, 2024 · 0 comments · May be fixed by #814

Comments

@ssbarnea
Copy link

Summary

While trying to run tests on macos, via tox -e py, I got an error complaining about missing some headers.

Actual result

      py_GeoIP.c:23:10: fatal error: 'GeoIP.h' file not found
      #include "GeoIP.h"

Expected result

Be able to run tets.

Environment

  • Operating system: Darwin m1 23.4.0 Darwin Kernel Version 23.4.0: Wed Feb 21 21:44:43 PST 2024; root:xnu-10063.101.15~2/RELEASE_ARM64_T6000 arm64
  • Linkchecker version: main branch
  • Python version: 3.12
  • Install method: pip

Configuration

Logs

Other notes

I installed the currently deprecated geoip from https://formulae.brew.sh/formula/geoip but that was not enough.

I think that it would be very useful to add a github actions pipeline that also runts the tests on macos, to catch such issues.

Interestingly I did not had problems using linkchecker itself on macos, only running the tests.

ssbarnea added a commit to ssbarnea/linkchecker that referenced this issue Mar 26, 2024
@ssbarnea ssbarnea linked a pull request Mar 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant