Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): export react server sub-entry #1762

Merged
merged 1 commit into from Sep 14, 2023
Merged

feat(react): export react server sub-entry #1762

merged 1 commit into from Sep 14, 2023

Conversation

thekip
Copy link
Collaborator

@thekip thekip commented Sep 14, 2023

Description

Exposing @lingui/react/server as sub-entry in package.json.

It seems i messed up somewhere because I clearly remember that I already did it (and local history in webstorm confirming it), but that somehow didn't go to the PR and was never merged to the master. Fixing this.

Related to: #1698

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Sep 14, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 7:46am

@github-actions
Copy link

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.73 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 1.66 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5838d2d) 75.95% compared to head (8f4efe4) 75.95%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1762   +/-   ##
=======================================
  Coverage   75.95%   75.95%           
=======================================
  Files          81       81           
  Lines        2063     2063           
  Branches      529      529           
=======================================
  Hits         1567     1567           
  Misses        383      383           
  Partials      113      113

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar merged commit fa77d82 into lingui:main Sep 14, 2023
14 checks passed
@andrii-bodnar andrii-bodnar linked an issue Sep 14, 2023 that may be closed by this pull request
NextJS App Router and RSC Support path #1698
Open
3 tasks
@thekip thekip deleted the feature/react-server-subentry branch September 14, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrii-bodnar andrii-bodnar andrii-bodnar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NextJS App Router and RSC Support path
2 participants
@thekip @andrii-bodnar