[Typescript] CompiledMessageToken type doesn't play well with imported catalog.

[zimme]

Describe the bug
I get type errors when trying to use my message catalogs.

To Reproduce
For the following code

import { messages as englishMessages } from "./locales/en/messages";
import { messages as swedishMessages } from "./locales/sv/messages";

i18n.loadLocaleData({
  en: { plurals: en },
  sv: { plurals: sv },
});

i18n.load({
  en: englishMessages, // Type errors here
  sv: swedishMessages, // Type errors here
});

...

I get the following type errors

Type '(string | string[])[]' is not assignable to type 'CompiledMessage'.
      Type '(string | string[])[]' is not assignable to type 'CompiledMessageToken[]'.
        Type 'string | string[]' is not assignable to type 'CompiledMessageToken'.
          Type 'string[]' is not assignable to type 'CompiledMessageToken'.
            Type 'string[]' is not assignable to type 'string'.ts(2322)

If I manually change the type CompiledMessageToken I can fix the error.

// Doesn't work
type CompiledMessageToken = string | [name: string, type?: string, format?: null | string | CompiledIcuChoices];

// Works, see the extra string[]
type CompiledMessageToken = string | string[] | [name: string, type?: string, format?: null | string | CompiledIcuChoices];

I believe the problem was introduced here. 88ac94a#diff-7a532cc8360c9c437a7693ba2c8767f39ce5e31dd36759d63a03c33286bb63b6L22-R29

Expected behavior
No type error when using imported catalogs

[zimme]

Typescript infers the type (string | string[])[] for some of my messages in my catalog.

I believe the message is something like this "Appointment with {0}" that's compiled into ["Appointment with ", ["0"]].

[pablohpsilva-forjnetwork]

Can we also get this warning fixed?

warning "workspace-aggregator-c7800d1b-27a7-41b4-b29b-317c787b474d > app > @lingui/[email protected]" has incorrect peer dependency **"typescript@2 || 3 || 4".**

TS released v5 :)

[vddgil]

Hello here,

I have the same issue but change the CompiledMessageToken type doesn't work. Here is the error:

Is any fix planned?

Thanks a lot!

[andrii-bodnar]

Currently, we have the v4 pre-release - https://github.com/lingui/js-lingui/releases

Could you please check if this is still relevant in this version? The latest version for now is 4.0.0-next.4

[vddgil]

Exactly the same issue:

And another issue with @lingui/macro ...

[vddgil]

Actually, maybe it will be fixed if I recompile the messages. But I'm not able to because of the @lingui/macro issue :(

[thekip]

@vddgil show the snippet which macro could not proceed, please

[vddgil]

Hello @thekip,
I deleted my node_module folder and did a fresh yarn install. With that, I got rid of the plugin error.
But I still have the type issue.

Here is a Gist of the problematic message.js file https://gist.github.com/vddgil/adb44581a952755b5cc1c3ec8cd479fc

Thanks a lot!

[mustafashabib]

Same issue.

In the very short term I've just changed our src/il8n/setup.ts to

import { i18n } from '@lingui/core';
import { messages as enMessages } from 'locales/en/messages';
import { messages as esMessages } from 'locales/es/messages';
import { en, es } from 'make-plural/plurals';

[
    { locale: 'en', messages: enMessages, plurals: en },
    { locale: 'es', messages: esMessages, plurals: es },
].forEach(({ locale, messages, plurals }) => {
    i18n.loadLocaleData(locale, { plurals });
    // @ts-expect-error Lingui introduced a type error in the CompiledMessage that needs string[] as a possible type of the value in the Record
    i18n.load(locale, messages);
});

i18n.activate('en');

[thekip]

guys, just cast it to any. Not a big deal. I would not recommend to use // @ts-expect-error because it mute all errors in the line, not only this one you intentionally want to mute.