Codify lint toolchain, Mk.II #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twey
force-pushed
the
11-16-Codify_lint_toolchain
branch
2 times, most recently
from
a5aa9c2
to
11d3b4a
Compare
Twey
force-pushed
the
11-16-Codify_lint_toolchain
branch
from
11d3b4a
to
c02a750
Compare
|
@Twey We're still missing tests |
Twey
force-pushed
the
11-16-Codify_lint_toolchain
branch
from
c02a750
to
ce9e1f2
Compare
Moves the nightly toolchain we use for linting out of a GitHub action and into a dedicated `toolchains/lint/rust-toolchain.toml` file. rustup doesn't currently support specifying a toolchain file, though [it will soon](rust-lang/rustup#2686), so we hack around it by moving the toolchain file back and forth as part of the GitHub action for Rust.
Twey
force-pushed
the
11-16-Codify_lint_toolchain
branch
from
ce9e1f2
to
f019946
Compare
Twey
force-pushed
the
11-16-Codify_lint_toolchain
branch
from
f019946
to
fa0664a
Compare
Twey
force-pushed
the
11-16-Codify_lint_toolchain
branch
from
fa0664a
to
5a47fcf
Compare
ma2bd
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implement #1251 without using
working-directory, which is apparently forbidden in combination withuses.