Disallow creating a repository with a .git suffix #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It is undesirable for repositories to be created with a `.git` suffix due to potential conflicts or confusion with Git's repository structure and management. Modifications: - Disallow creating a repository whose suffix is `.git` Result: - You can no longer create a repository whose suffix is `.git`
jrhee17
approved these changes
Jun 13, 2024
| @@ -437,7 +438,8 @@ private static boolean isValidChildName(String name) { | |||
| return false; | |||
| } | |||
|
|
|||
| return !name.endsWith(SUFFIX_REMOVED) && !name.endsWith(SUFFIX_PURGED); | |||
| return !name.endsWith(SUFFIX_REMOVED) && !name.endsWith(SUFFIX_PURGED) && | |||
| !name.endsWith(GIT_EXTENSION); // Git repository whose name ends with '.git' is not allowed. | |||
There was a problem hiding this comment.
Note: I understood if there are any users out there who use .git suffixes, the project/repositories just won't be loaded server start-up will be successful.
There was a problem hiding this comment.
That was my intention. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It is undesirable for repositories to be created with a
.gitsuffix due to potential conflicts or confusion with Git's repository structure and management.Modifications:
.gitResult:
.git