Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

high cpu after 32 days with caddy-s3-proxy #64

Open
Dinfangion opened this issue Oct 19, 2023 · 3 comments
Open

high cpu after 32 days with caddy-s3-proxy #64

Dinfangion opened this issue Oct 19, 2023 · 3 comments

Comments

@Dinfangion
Copy link

https://github.com/caddyserver/caddy/issues/5647
@Dinfangion
Copy link
Author

pprof output debug
pprof001-debug

@Dinfangion
Copy link
Author

Dinfangion commented Oct 19, 2023 •
edited
Loading

pprof output heap
pprof001-heap

@mcrute
Copy link

mcrute commented Jul 26, 2024 •
edited
Loading

I'm seeing something similar to this as well as OOM killing of the Caddy process. A quick glance at the code and it's not closing the Body of its S3 responses, which are just plain http.Response structs (if you dig deep enough into the SDK). My guess is that it's leaking memory. Preparing and testing a patch to see if this is the case.

@mcrute mcrute mentioned this issue Jul 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Close GetObject bodies to avoid leaking memory mcrute/caddy-s3-proxy
2 participants
@mcrute @Dinfangion