Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConstructListObjInput function is incorrectly trimming the 'key' string #53

Open
BrianFanning opened this issue Feb 1, 2022 · 1 comment
Open

ConstructListObjInput function is incorrectly trimming the 'key' string #53

BrianFanning opened this issue Feb 1, 2022 · 1 comment

Comments

@BrianFanning
Copy link
Contributor

I will open a PR shortly with a fix.

The key argument passed to ConstructListObjInput function is a path such as /my_folder/. The function trims the final / off the path, but instead it should remove the leading /. Prefixes do not start with a / character.

The trailing / should not be removed if you want to provide browse-style functionality. Take a look at the third example here from the official API docs
BrianFanning added a commit to BrianFanning/caddy-s3-proxy that referenced this issue Feb 1, 2022
@BrianFanning
Fix for lindenlab#53
1450bad
@BrianFanning BrianFanning mentioned this issue Feb 3, 2022
Merged
@porkcharsui porkcharsui mentioned this issue Apr 29, 2022
Open
rayjlinden pushed a commit that referenced this issue May 31, 2023
@BrianFanning
Fix for #53 (#54)
ab7902b
@almereyda
Copy link

As #54 is merged now, I suspect this here can be closed, too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@almereyda @BrianFanning