Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnvCpt clarification #96

Open
rkillick opened this issue Oct 27, 2020 · 2 comments
Open

EnvCpt clarification #96

rkillick opened this issue Oct 27, 2020 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@rkillick
Copy link

I was happy to see that EnvCpt is included in your comparison documentation, thanks for including it.

In a couple of places you write "I suspect EnvCpt uses cpt.np() in the background" for the change in mean parts. I wanted to clarify that it is using cpt.meanvar() from the changepoint package. You will see that the changepoint.np package is not a dependency and therefore it could not use this in the background.

This explains the differences you see between EnvCpt and the cpt.mean() function.

@lindeloev
Copy link
Owner

Thanks for noting this! I'll update the doc.

Do you know why EnvCpt and cpt.meanvar() do not find the same change points in the example?

@rkillick
Copy link
Author

Line 23 from the envcpt() function is:

meancpt.fit=cpt.meanvar(data,method='PELT',minseglen=minseglen,...) # default MBIC penalty

thus it will give the same answer. The default minseglen argument for envcpt is 5 though whereas for cpt,meanvar it is 2 so this may be why there are differences.

@lindeloev lindeloev added the documentation Improvements or additions to documentation label Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants