Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download command for published versions displays the resource identifier with the DANDI prefix #163

Open
kabilar opened this issue May 3, 2024 · 3 comments

Comments

@kabilar
Copy link
Member

kabilar commented May 3, 2024

On production (i.e. lincbrain.org), the download command for published versions displays the resource identifier with the DANDI prefix (e.g. lincbrain download DANDI:000005/0.240423.1444). Should we update this prefix from DANDI to LINCBRAIN? We may also have to update the lincbrain-cli, but not sure what else might break.

On staging, the download command for published versions also displays the DANDI prefix. Perhaps we should update the prefix to LINCBRAIN-STAGING, or something else?

Thank you.

cc @aaronkanzer

@aaronkanzer
Copy link

@kabilar unfortunately, this naming convention is validated via dandischema

https://github.com/dandi/dandi-schema/blob/be57e138505819a46475f8f5a590e6f6b00cd1b2/dandischema/models.py#L53

https://github.com/dandi/dandi-schema/blob/be57e138505819a46475f8f5a590e6f6b00cd1b2/dandischema/models.py#L1588-L1593

Not sure how you'd like to proceed -- seems that we'd have to break some validation/do a bit more refactoring than necessary for a non-feature here.

@kabilar
Copy link
Member Author

kabilar commented Jul 23, 2024

Thanks for looking into this, Aaron. Now that I recall there is an issue on the DANDI Org that discusses this item. I will ping that issue. Let's defer to the DANDI team on how to best approach.

@kabilar
Copy link
Member Author

kabilar commented Jul 23, 2024

dandi/dandi-schema#76

This issue will include several components so we may have to defer to a later time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants