Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for expo-image or other components #35

Closed
slytter opened this issue Nov 13, 2023 · 5 comments
Closed

Support for expo-image or other components #35

slytter opened this issue Nov 13, 2023 · 5 comments
Labels
enhancement New feature or request Stale

Comments

@slytter
Copy link

slytter commented Nov 13, 2023

Is your feature request related to a problem? Please describe.
expo-image is beginning to take over <Image/> component from react native.

Describe the solution you'd like
Instead of making a new exported component maybe we could implement a createZoomComponent, which would make any kind of component zoomable, with your current implementation.

Then you could go:

import { createZoomComponent } from 'react-native-image-zoom'
import { Image } from 'expo-image'

const ZoomableImage = createZoomComponent(Image)

const MyComponent = () => {
    return <ZoomableImage 
         // ...expo-image props here
    />
}

Describe alternatives you've considered
Another way would be to implement a <ZoomableView>{children}</ZoomableView> kind of component that could just make any child component zoomable.

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Jan 12, 2024
@likashefqet likashefqet added enhancement New feature or request and removed Stale labels Jan 21, 2024
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@irenerhee
Copy link

I'd be interested in this too!

Copy link

github-actions bot commented Jun 1, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

@github-actions github-actions bot added the Stale label Jun 1, 2024
Copy link

This issue was closed because it has been stalled for 15 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

3 participants