Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to be able to not re-run a query when I'm adding filters/sorting in Lightdash #10080

Open
TuringLovesDeathMetal opened this issue May 15, 2024 · 1 comment
Labels
✨ feature-request Request for a new feature or functionality ✍️ needs spec Label used for issues that still require speccing before they can be picked up.

Comments

@TuringLovesDeathMetal
Copy link
Contributor

TuringLovesDeathMetal commented May 15, 2024

Description

Today, every time I add a new filter or a new sort to my results, a query gets rerun in Lightdash.

This is fine if I'm working with a tiny table, but if my table is say 1TB, then this is really time-consuming and takes a really long time for me to do anything.

I don't know the right answer here. It could be a combination of backend changes which result in us caching data smartly so that we can update ordering adn filtering quite quickly as well as UX/UI changes where there's a way to stop queries from running automatically (and you have to manually click run query each time instead).

It's also an odd pattern today, so it's hard to know when to click run query vs. not. E.g.

  • adding a dimension/metric to my table doesn't run a new query
  • adding a table calculation runs a query
  • adding a new filter doesn't run a query
  • adding sorting runs a query (with each new change I make to sorting).

To add a bit of focus here: I think the goal of this ticket should be to make it easy for users with large tables to update their queries in the Explore view without needing to wait a long time (e.g. I can add/update table calculations, change sorting, and add new filters without needing to run 4 new full queries - this could just be a caching issue!).

How we do that, I'm not sure! But it will probably require a couple of changes, instead of one small change.

@TuringLovesDeathMetal TuringLovesDeathMetal added ✨ feature-request Request for a new feature or functionality ✍️ needs spec Label used for issues that still require speccing before they can be picked up. labels May 15, 2024
@TuringLovesDeathMetal
Copy link
Contributor Author

Potential solution: Adding a button near run query which you can set to auto refresh or not auto refresh.

By default, it's set to auto refresh. We'd need to change the current behaviour so that adding metrics/dimensions + filters to your query would automatically re-run the query (so it's more consistent)

You can change it to no auto refresh which would make it so that nothing would re-run a query unless you clicked run query.

Ideally, I think that sorting would be something we could do using cache-ing 👀 (that's the one thing that feels weird that it doesn't auto-update with this change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature-request Request for a new feature or functionality ✍️ needs spec Label used for issues that still require speccing before they can be picked up.
Projects
None yet
Development

No branches or pull requests

1 participant