Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support For AWS Athena As Source #3554

Open
IstvanM opened this issue Oct 23, 2022 · 18 comments · May be fixed by #10020
Open

Support For AWS Athena As Source #3554

IstvanM opened this issue Oct 23, 2022 · 18 comments · May be fixed by #10020
Labels
✨ feature-request Request for a new feature or functionality

Comments

@IstvanM
Copy link

IstvanM commented Oct 23, 2022

Description

Support for Athena

What problem does this solve?

Many startups don't have the budget to run Databricks or Snowflake as their Data Lake solution. Athena is currently the cheapest on the market.

@IstvanM IstvanM added the ✨ feature-request Request for a new feature or functionality label Oct 23, 2022
@TuringLovesDeathMetal
Copy link
Contributor

Hey @IstvanM thanks for opening this issue!

We only support verified dbt adapters for now. You can find the list of verified adapters here: https://docs.getdbt.com/docs/supported-data-platforms#verified-adapters

Once Athena gets onto that list, we'll definitely work on adding support for it in Lightdash!

@TuringLovesDeathMetal
Copy link
Contributor

@all-contributors add @IstvanM for ideas

@allcontributors
Copy link
Contributor

@TuringLovesDeathMetal

I've put up a pull request to add @IstvanM! 🎉

@IstvanM
Copy link
Author

IstvanM commented Nov 16, 2022

Thank you very much!!! This is great!!! Sorry I was not responding fast enough

🚀 🚀 🚀

@stale
Copy link

stale bot commented Jan 15, 2023

Is this issue still relevant? There have been no updates for 60 days, please close the issue or keep the conversation going!

@stale stale bot added the stale Issue hasn't been updated for 60 days label Jan 15, 2023
@jankatins
Copy link

Still relevant

@stale stale bot removed the stale Issue hasn't been updated for 60 days label Apr 12, 2023
This was referenced Apr 12, 2023
@nicor88
Copy link

nicor88 commented Apr 12, 2023

The only blocker to make this happen is the verification of dbt-athena-community (the adapter with the most recent version of dbt).

Related to dbt-labs/dbt-core#7286
Specifically, the process of verifying a community-based adapter seems a bit unclear.

@stale
Copy link

stale bot commented Jun 11, 2023

Is this issue still relevant? There have been no updates for 60 days, please close the issue or keep the conversation going!

@stale stale bot added the stale Issue hasn't been updated for 60 days label Jun 11, 2023
@mrshu
Copy link

mrshu commented Jun 15, 2023

@nicor88 I guess the verification procedure has been settled now somewhat?

https://docs.getdbt.com/guides/dbt-ecosystem/adapter-development/7-verifying-a-new-adapter

@stale stale bot removed the stale Issue hasn't been updated for 60 days label Jun 15, 2023
@nicor88
Copy link

nicor88 commented Jun 15, 2023

@mrshu the verification process is still quite unclear, as in the case of athena the adapter is community based - and all the verified adapters (e.g. see trino), have a company behind.

@stale
Copy link

stale bot commented Aug 16, 2023

Is this issue still relevant? There have been no updates for 60 days, please close the issue or keep the conversation going!

@stale stale bot added the stale Issue hasn't been updated for 60 days label Aug 16, 2023
@mrshu
Copy link

mrshu commented Aug 16, 2023

Thanks @nicor88. Would you estimate it might ever happen?

@nicor88
Copy link

nicor88 commented Aug 16, 2023

@mrshu Based on the conversations that I had with dbt seems like a dbt community adapter cannot be verified. Still, they are in the process of considering adding trusted adapters - that means that if Lightdash consider the support of "trusted" adapters and if dbt-athena becomes a trusted adapter, then this integration will be possible.

@stale stale bot removed the stale Issue hasn't been updated for 60 days label Aug 16, 2023
@nicor88
Copy link

nicor88 commented Sep 7, 2023

@TuringLovesDeathMetal dbt-athena-community became a trusted adapter: https://docs.getdbt.com/docs/trusted-adapters wondering if you plan to support not only verified but also trusted adapters.

cc @owlas

@darkcofy
Copy link

would love to have this integration, would make lightdash an easy choice for us if it works with athena

@amartinezcortizas
Copy link

One more, would love to have the chance of testing lightdash with athena

@ankit-shopflo
Copy link

+1 would love to use lightdash with Athena

@SOVALINUX
Copy link

Would love also to upvote the Athena adapter

@hhhonzik hhhonzik linked a pull request May 8, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature-request Request for a new feature or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants