Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnsureNodeFiles not robust enough #1

Open
cmxl opened this issue Aug 21, 2018 · 1 comment
Open

EnsureNodeFiles not robust enough #1

cmxl opened this issue Aug 21, 2018 · 1 comment

Comments

@cmxl
Copy link

cmxl commented Aug 21, 2018

I use the WebOptimizer.LESS and WebOptimizer.Typescript packages with the latest beta build.

Following folders will be populated with the node_packages:
%TEMP%\WebOptimizer.Node\LESS\
%TEMP%\WebOptimizer.Node\TypeScript\

As long as the folders did not exist before, everything works fine.
But somehow the initial files %TEMP%\WebOptimizer.Node\LESS\index.js and %TEMP%\WebOptimizer.Node\TypeScript\typescript.js were gone on my PC (maybe my antivirus software removed them).

The next runs never recreated those files because it is only ensured, that the certain folder exists, but never the needed files. Maybe EnsureNodeFiles needs to be abstract to check for those files in the concrete implementations.

PS.: I don't know if I should post this issue in the other repos, because it is somehow referred to the
EnsureNodeFiles function of the NodeProcessor.

@cmxl
Copy link
Author

cmxl commented Apr 26, 2019

This is a very old issue, but wanted to revive it, because it still is an issue on some systems where I use WebOptimizer.

Changing the base class would also mean to update all the dependent packages to properly handle EnsureNodeFiles.

I don't know if this is practical, but I'd like to help out.

Any thoughts @madskristensen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant