Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore contains files in wwwroot/dist which will not be automatically be created #21

Open
SamJost opened this issue Dec 28, 2016 · 5 comments

Comments

@SamJost
Copy link

SamJost commented Dec 28, 2016

  • Visual Studio: Enterprise 2015 14.0.25431.01 Update 3
  1. Create a new Project with the angular 2 spa template
  2. check the project into git
  3. clone the git repo in a new directory
  4. try to rebuild/run will not work because some files are missing:
    wwwroot/dist/89889688147bd7575d6327160d64e760.svg
    wwwroot/dist/vendor.css
    wwwroot/dist/vendor.js

The error message fails to load the web page due to missing wwwroot/dist/vendor-manifest.json file.

Probably these files should not be excluded from git by using .gitignore?

@SteveSandersonMS
Copy link
Contributor

It's up to you. Since those a build artifacts, it's normal not to commit them into source control.

@SamJost
Copy link
Author

SamJost commented Jan 10, 2017

When they are created, yes, they should be ignored.
But for some reason they do not get created when I check out the project and open it in VS.

@SteveSandersonMS
Copy link
Contributor

They are created when running webpack, which is best thought of as being part of building the project (though it's not wired into the build process as far as MSBuild is concerned, because often you'd want to build .NET code independently and not wait for a webpack build).

@SamJost
Copy link
Author

SamJost commented Jan 10, 2017

Ok, so maybe it just needs some documentation how to build those after checking out a project?
I still don't understand really what needs to happen so these will be build. They are updated even though I don't run webpack manually, so if it is not a buildstep, what is the magic glue running webpack?

@icsimlai
Copy link

Just wondering why there was no response on the question asked by SamJost. Needs some documentation please...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants