New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
win: use WinDNS family of functions for DNS resolving #4388
Comments
Superior how?
DnsQueryEx is only available on Windows 8 so would have to be feature-tested at runtime. It would also be good to double-check if it's really asynchronous and not just using the Windows thread pool. Replacing GetAddrInfoW with DnsQuery_W doesn't seem compelling on its own but DnsQueryEx might be a good reason to switch. It should be 100% backwards compatible though. |
We dropped support for windows 8 when Microsoft ended support |
I've also tried I actually want to take part in implementing it, I thought this might be a good first issue as well. |
The GetAddrInfoExW looks better, since it is in the existing ws2_32 library and seems to support passing an Event object via OVERLAPPED (which can be used with IOCP directly) |
Currently
GetAddrInfoW
is used for DNS queries on Windows. WinDNS functions seems superior to getaddrinfo and it's counterparts. We have:and
DnsQueryEx
which does an asynchronous procedure call so it eliminates the need for thread pool (also supports wide characters).The text was updated successfully, but these errors were encountered: