Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dist-hook instead of listing directories in EXTRA_DIST #4205

Open
diizzyy opened this issue Nov 7, 2023 · 2 comments
Open

use dist-hook instead of listing directories in EXTRA_DIST #4205

diizzyy opened this issue Nov 7, 2023 · 2 comments

Comments

@diizzyy
Copy link

diizzyy commented Nov 7, 2023

Hi,

New dist file with generated documentation (-dist) and configure script is now over 6Mbyte in size (1.47.0) which is quite a jump from 1.46.0. Switching to xz/lzma would cut this is in more than half, downside is that it takes slightly longer to generate but given it's a small library I think that's worth the tradeoff.

@diizzyy diizzyy changed the title Consider uzing xz/lzma compression for release archives Consider switcing to xz/lzma compression for release archives Nov 7, 2023
@vtjnash
Copy link
Member

vtjnash commented Nov 7, 2023

I fixed the current files and re-released those.

It seems the trouble is the way we use EXTRA_DIST
https://www.gnu.org/software/automake/manual/html_node/Basics-of-Distribution.html

libuv/Makefile.am

Lines 121 to 131 in 815693f

EXTRA_DIST = test/fixtures/empty_file \
test/fixtures/load_error.node \
test/fixtures/lorem_ipsum.txt \
test/fixtures/one_file/one_file \
include \
docs \
img \
CONTRIBUTING.md \
LICENSE \
LICENSE-extra \
README.md

I am not sure of a good way around that, since we cannot use git ls-tree in the dist tree (the git files are not copied) and we cannot even use $(wildcard) or find since automake will error with a warning it is non-portable.

@vtjnash vtjnash changed the title Consider switcing to xz/lzma compression for release archives use dist-hook instead of listing directories in EXTRA_DIST Nov 7, 2023
@diizzyy
Copy link
Author

diizzyy commented Nov 7, 2023

Thanks!

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Nov 7, 2023
Upstream repackaged 1.47.0 due to a bug in release script

Source:
libuv/libuv#4205 (comment)

Approved by:	portmgr (blanket, build fix)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants