Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong button parameter 'pct' (should be 'saturate_pct') #72

Open
Valent-in opened this issue Nov 9, 2021 · 1 comment
Open

Wrong button parameter 'pct' (should be 'saturate_pct') #72

Valent-in opened this issue Nov 9, 2021 · 1 comment

Comments

@Valent-in
Copy link
Contributor

All analog sticks has overlayX_descY_pct = 0.65 parameter which should describe stick sensitivity. But in fact this does nothing, because valid parameter name is overlayX_descY_saturate_pct = 0.65

Docs:
https://docs.libretro.com/development/retroarch/input/overlay/

Source:
https://github.com/libretro/RetroArch/blob/ed3412c0040622488fe46431d1c17e8bf837e0d6/tasks/task_overlay.c#L261

This is 'reverse sensitivity': smaller value = more sensitive analog.
I think just 'fixing' param name in overlays or in RetroArch is bad idea because all analogs become too sensitive. Size of this button should be increased accordingly to saturate_pct value. Notice the image thumbstick-pad_arcade.png from 'flat' overlay pack - it already has transparent padding so visual size is smaller than actual hitbox. Is it designed for use with this parameter?
I think best value for this param is 0.5 - thumbstick image sticks exactly under touchpoint.

You can use online editor to test this. Default image set contains all images from RetroArch 'flat' overlays.
https://github.com/Valent-in/retropad-editor

Valent-in added a commit to Valent-in/common-overlays that referenced this issue Nov 14, 2021
@jeffWhitridge
Copy link

jeffWhitridge commented Mar 10, 2022

I used Notepad++ to do a "Find In Files" search for "_saturate_pct" in all ".cfg" files in the "overlays" folder and sub folders and got 0 hits.
Then I searched for "_pct" and got 51 hits in 21 files.

I also confirmed that it does in fact need to be:
E.g. overlay0_desc3_saturate_pct = 0.75 and not overlay0_desc3_pct = 0.75 in order to work.

Simple fix to retain the current behavior would be to change all occurrences of _pct = 0.XX to _saturate_pct = 1.00 so that people who are editing the files (Like I was) will know what the correct format to use is.
Or just delete the lines since they don't do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants